fix(22.04/libnss3): libs should contain all libraries #382
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restructures the libnss3 slices. It renames the former "libs" slice to "nss", to only include nss3-specific libraries. It also adds a new slice "smime" to include S/MIME libraries. Finally, the "libs" slice is added back, which includes all of the slices that provide libraries. The rationale is that "libs" slices should contain all libraries coming from the package. Note that the ca-certificates-java slice has also been updated to reflect this change. Resolves canonical#381
|
Diff of dependencies: slices/ca-certificates-java.yaml@@ -1,4 +1,2 @@
ca-certificates
-default-jre-headless
-java8-runtime-headless
libnss3 |
rebornplusplus
commented
Oct 24, 2024
|
@vpa1977, will you please take a look at this PR? I could not add you to the reviewers list up there on the top-right. |
I also can not add myself to reviewers. This is used in pkcs11 implementation of openjdk https://github.com/openjdk/jdk/blob/f0b130e54f33d3190640ce33c991e35f27e9f812/test/jdk/sun/security/tools/keytool/KeyToolTest.java#L38 I would suggest supplying the slice and adding a note in openjdk security slices. |
vpa1977
reviewed
Oct 31, 2024
| @@ -23,6 +23,7 @@ slices: | |||
| essential: | |||
| - libc6_libs | |||
| - libnspr4_libs | |||
| - libsqlite3-0_libs | |||
| contents: | |||
| /usr/lib/*-linux-*/libnss3.so: | |||
| /usr/lib/*-linux-*/libnssutil3.so: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the libnss3 slices. It renames the former
libsslice tonss, to only include nss3-specific libraries. It also adds a new slicesmimeto include S/MIME libraries.Finally, the
libsslice is added back, which includes all of the slices that provide libraries. The rationale is that "libs" slices should contain all libraries coming from the package.Note that the ca-certificates-java slice has also been updated to reflect this change.
Resolves #381