feat: add file and directory report skeleton #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating files as part of the cut command, we will use a proxy that logs information about the hash, path, mode, etc. This will then be ingrated into a report which will be part of chisel.db.
The report will be the main data source for chisel.db.
rebornplusplus
approved these changes
Feb 9, 2024
letFunny
commented
Feb 9, 2024
niemeyer
requested changes
Feb 26, 2024
| } else { | ||
| c.Assert(treeDumpFSCreator(creator, dir), DeepEquals, test.result) | ||
| } | ||
| // [fsutil.Create] does not return information about parent directories |
There was a problem hiding this comment.
The bracketed naming doesn't seem typical. I believe the typical convention in Go is to document types cleanly (foo.Bar), or has something changed in this regard recently?
There was a problem hiding this comment.
I saw that you can use brackets for documentation links here: https://tip.golang.org/doc/comment#doclinks
1 task
niemeyer
requested changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report will be the main data source for chisel.db. This PR introduces the skeleton and the reporting functionality in the package extractor.
Tests for checking the final report after slicing have been intentionally omitted. Until we land #113, it is very difficult to inspect and change the slicer tests. On top of that right now the tests would be meaningless because they do not conform to the business logic of chisel.db. Because we are developing the feature iteratively in small PRs, I will add the rest of business logic in the next PR together with all the tests. At that point we can inspect them and now if the implementation is working or not and discuss corner cases.