feat: validate manifest before writing

[letFunny]

• Have you signed the CLA?

---

[rebornplusplus]

Looks good to me! I left a comment below about a function name.

[niemeyer]

Very nice, thanks. Only a trivial adding some notes to fastValidate.

[niemeyer]

Can we please add:

// fastValidate validates the data to be written into the manifest.
// This is validating internal structures which are supposed to be correct unless there is
// a bug. As such, only assertions that can be done quickly are performed here, instead
// of it being a comprehensive validation of all the structures.

[niemeyer]

I went ahead and edited it as it's just an additional comment.

[niemeyer]

Thanks for the new tests.

[endersonmaia]

Sorry to make the question here.

What's the plan, add a an essential manifest slice to all packages like we have for copyright?

ex.:

package: libc6

essential:
  - libc6_copyright
  - libc6_manifest

slices:
(...)

  copyright:
    contents:
      /usr/share/doc/libc6/copyright:

  manifest:
    contents:
      /var/lib/chisel/**: {generate:  manifest}

[rebornplusplus]

It doesn't need to be in essential. If you install the libc6_manifest slice along with the other slices you want to install, you will get a valid chisel manifest at /var/lib/chisel/manifest.wall. It's a zstd-compressed, JSON file.

We actually do provide the slice as of this writing. It's base-files_chisel in the current releases.

[endersonmaia]

So, what I understood was:

base-files_chisel is a slice that when installed will feed the manifest with information from all other package slices installed together in the same chisel cut action.

And *_manifest is a "virtual" slice that's available for all packages, that when installed will feed the manifest with information from all other slices that are its dependencies on the same chisel cut action.

Am I right?

[rebornplusplus]

base-files_chisel is a slice that when installed will feed the manifest with information from all other package slices installed together in the same chisel cut action.

Correct.

And *_manifest is a "virtual" slice that's available for all packages, that when installed will feed the manifest with information from all other slices that are its dependencies on the same chisel cut action.

Nope. *_manifest does not exist, not even virtually. You may create those, similar to base-files_chisel. But you don't really need multiple slices like base-files_chisel, unless you want to create multiple manifest file with (almost, if not) the same contents.