Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper HTTP clients to fetch files #66

Merged
merged 6 commits into from
Sep 17, 2023

Commits on Jun 16, 2023

  1. fix: add --timeout option in cut command

    Add ``--timeout`` option in chisel cut so that users can
    specify their preferred limit for each request to avoid
    context deadline error [0].
    
    Duration (with unit) should be specified as the argument of
    the new option. A timeout of zero means no timeout. Default
    timeout is 60 seconds.
    
    Additionally, increase the hardcoded Timeout in the http
    client in archive.go to match the default 60 seconds limit.
    
    Fixes canonical#14.
    
    References:
    - [0] canonical#14
    rebornplusplus committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    62b704e View commit details
    Browse the repository at this point in the history
  2. Add test for --timeout

    Pass --real-archive option in go test to run this
    test with real archives.
    rebornplusplus committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    674f42e View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. CI: test ./internal/archive/ with --real-archive

    The --real-archive flag specified in archive_test is used
    to test real archives and timeout limits. Run these tests
    in the github workflow.
    rebornplusplus committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    3a6f140 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4dee683 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Revert "fix: add --timeout option in cut command"

    This reverts commit 62b704e.
    rebornplusplus committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    06ee7b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be06f05 View commit details
    Browse the repository at this point in the history