testutil/pkgdata: Handle empty names in MakeDeb() #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakeDeb() now expects that all provided tar entries have a non-empty name. Otherwise it panics on array out of bounds access. Fix it. We can create tarballs containing entries with empty name just fine. It makes GNU tar fail when extracting, but it fails gracefully with tar: Substituting `.' for empty member name -rw-r--r-- root/root 0 1970-01-01 01:00 tar: .: Cannot open: File exists tar: Exiting with failure status due to previous errors
woky
force-pushed
the
pub/testutil-pkgdata-empty-names
branch
from
4c652ba
to
990f689
Compare
woky
changed the title
niemeyer
approved these changes
Aug 28, 2023
| }, { | ||
| testutil.TarEntry{ | ||
| Header: tar.Header{ | ||
| Name: "", |
There was a problem hiding this comment.
That feels like a strange case that makes me tempted to just complain about. That said, this is a test package, so I can imagine it being used precisely for testing, so sounds okay I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MakeDeb() now expects that all provided tar entries have a non-empty
name. Otherwise it panics on array out of bounds access. Fix it.
We can create tarballs containing entries with empty name just fine. It
makes GNU tar fail when extracting, but it fails gracefully with
tar: Substituting `.' for empty member name
-rw-r--r-- root/root 0 1970-01-01 01:00
tar: .: Cannot open: File exists
tar: Exiting with failure status due to previous errors