Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: test number coercion #465

Closed
wants to merge 3 commits into from
Closed

tests: test number coercion #465

wants to merge 3 commits into from

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented Sep 13, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

This is still failing and I haven't figured out why!

lengau
lengau approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mr-cal
Copy link
Contributor Author

mr-cal commented Sep 13, 2024

See failure here: https://github.com/canonical/craft-application/actions/runs/10849785146/job/30109724650?pr=465#step:7:76

@mr-cal mr-cal mentioned this pull request Sep 13, 2024
Closed
3 tasks
@mr-cal
Copy link
Contributor Author

mr-cal commented Sep 18, 2024

Fixed upstream in canonical/craft-grammar#50

@mr-cal mr-cal closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-cal @lengau