feat: add a utility function that determines whether a part has slices #637
+30
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tigarmo Ready for review. |
|
Tagging @cmatsuoka @lengau @mr-cal for review. Failing integreation test is due to network connection issue so it needs a retrigger. |
1 task
SamirPS
approved these changes
Jan 26, 2024
cmatsuoka
reviewed
Jan 29, 2024
tigarmo
requested changes
Feb 5, 2024
linostar
force-pushed
the
ROCKS-970/util-function-for-determining-if-parts-have-slices
branch
3 times, most recently
from
c71971d
to
71d1b19
Compare
linostar
force-pushed
the
ROCKS-970/util-function-for-determining-if-parts-have-slices
branch
from
71d1b19
to
727e012
Compare
|
I have changed the utility function to a property, and added unit tests for it. This is to accomodate the function to how similar functions are unit tested. |
lengau
approved these changes
Feb 15, 2024
|
@linostar could you rebase this on main and resolve the conflicts here? |
SamirPS
approved these changes
Aug 29, 2024
cmatsuoka
reviewed
Oct 8, 2024
|
@cmatsuoka @tigarmo Can we merge this PR if there are no further comments, so that we can move forward with canonical/rockcraft#464? |
SamirPS
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A utility function is needed in rockcraft to determine whether parts has slices in them.
Instead of implementing such a function in rockcraft, it is better to implement it in craft-parts instead.