feat(docs): scons plugin reference #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sergiusens
commented
Apr 19, 2024
sergiusens
commented
- Have you signed the CLA?
Signed-off-by: Sergio Schvezov <[email protected]>
lengau
reviewed
Apr 19, 2024
tigarmo
requested changes
Apr 19, 2024
| @@ -0,0 +1,61 @@ | |||
| .. _craft_parts_scons_plugin: | |||
|
|
|||
| Scons plugin | |||
|
|
||
| The Scons plugin builds projects using Scons_. | ||
|
|
||
| After a successful build, this plugin will installs the generated |
There was a problem hiding this comment.
Suggested change
| After a successful build, this plugin will installs the generated | |
| After a successful build, this plugin will install the generated |
| Dependencies | ||
| ------------ | ||
|
|
||
| The Scons plugin needs the ``scons`` executable work. |
There was a problem hiding this comment.
should also mention that the plugin itself does NOT provision scons
There was a problem hiding this comment.
yeah, I recalled this when I was picking up my kids. I was wondering why I had not submitted it by then. thanks!
lengau
reviewed
Apr 19, 2024
Co-authored-by: Alex Lowe <[email protected]> Co-authored-by: Tiago Nobrega <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
lengau
approved these changes
Apr 23, 2024
tigarmo
approved these changes
Apr 23, 2024
tigarmo
added a commit
that referenced
this pull request
May 17, 2024
Signed-off-by: Sergio Schvezov <[email protected]> Co-authored-by: Alex Lowe <[email protected]> Co-authored-by: Tiago Nobrega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.