Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partitions feature documentation #763

Merged
merged 14 commits into from
Jul 1, 2024

Conversation

mattculler
Copy link
Contributor

@mattculler mattculler commented Jun 25, 2024

  • Have you signed the CLA?

Write documentation for application developers who want to use partitions.

(CRAFT-3030)

@mattculler mattculler self-assigned this Jun 25, 2024
docs/how-to/partitions.rst Outdated Show resolved Hide resolved
@mattculler mattculler marked this pull request as ready for review June 26, 2024 01:54
@mattculler mattculler requested a review from a team June 26, 2024 01:55
@mattculler mattculler force-pushed the work/CRAFT-3030-document-partitions branch from 3b75ba9 to 9c559b5 Compare June 26, 2024 19:23
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation itself looks great! I have some opinions on the location and separation of how-to and reference.

docs/how-to/partitions.rst Outdated Show resolved Hide resolved
docs/how-to/partitions.rst Outdated Show resolved Hide resolved
docs/how-to/partitions.rst Outdated Show resolved Hide resolved
docs/how-to/partitions.rst Outdated Show resolved Hide resolved
@mattculler mattculler requested a review from a team June 26, 2024 20:39
@mattculler mattculler force-pushed the work/CRAFT-3030-document-partitions branch from 221bd37 to 2111397 Compare June 27, 2024 15:08
docs/how-to/partitions.rst Outdated Show resolved Hide resolved
docs/how-to/partitions.rst Outdated Show resolved Hide resolved
docs/how-to/partitions.rst Outdated Show resolved Hide resolved
docs/how-to/partitions.rst Outdated Show resolved Hide resolved
docs/how-to/partitions.rst Outdated Show resolved Hide resolved
@mr-cal mr-cal requested a review from a team June 28, 2024 20:38
@@ -90,6 +90,22 @@ to the ``bin`` directory in the staging area and renamed to ``hello``:
organize:
hello.py: bin/hello

If partitions are in use by the application, they may be referenced by prepending the partition name, surrounded by parentheses, to the destination path. Only the destination path may specify a partition; source paths always reference the ``default`` partition. Omitting the partition name in the destination path causes the file to be copied to the ``default`` partition.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuff that mentions partitions should have a way to ignore them when including the file (e.g. a header so we can have an end_before).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lengau I don't understand what you mean. I'm going to mark this resolved for now, I expect to make another pass on the docs as I implement partitions and we can address this then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stuff that's in the common directory gets included in other projects. Rockcraft for example includes these files but doesn't have partitions enabled, so we should have a way to exclude the info about partitions from the Rockcraft docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh ok gotcha, thank you! I'll do this on the next round.

@mattculler mattculler requested a review from a team July 1, 2024 12:05
@sergiusens sergiusens merged commit cdcc9db into main Jul 1, 2024
5 of 10 checks passed
@sergiusens sergiusens deleted the work/CRAFT-3030-document-partitions branch July 1, 2024 16:10
@mr-cal mr-cal mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants