-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: restructure plugin models #775
Merged
lengau
merged 11 commits into
feature/2.0
from
work/CRAFT-2913/2-refactor-plugin-models
Jul 12, 2024
Merged
chore!: restructure plugin models #775
lengau
merged 11 commits into
feature/2.0
from
work/CRAFT-2913/2-refactor-plugin-models
Jul 12, 2024
Commits on Jul 10, 2024
-
chore!: remove PluginModel class
This class was vestigial, being a child of PluginPropertiesModel, while all plugins' properties classes are children of PluginProperties, which is itself a child of PluginPropertiesModel. This is a breaking change because external plugins for applications (e.g. snapcraft) inherit from both PluginProperties and PluginModel.
Configuration menu - View commit details
-
Copy full SHA for 257af9f - Browse repository at this point
Copy the full SHA 257af9fView commit details -
feat!(plugins): make PluginProperties more complete
This does several things: - Merges PluginProperties and PluginPropertiesModel - Makes PluginProperties.unmarshal() work for most plugins be default - Makes PluginProperties.marshal() fully dump json-able objects - Adds a `plugin` field to all plugins, providing their names.
Configuration menu - View commit details
-
Copy full SHA for 2d2e216 - Browse repository at this point
Copy the full SHA 2d2e216View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1899868 - Browse repository at this point
Copy the full SHA 1899868View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d9308d - Browse repository at this point
Copy the full SHA 3d9308dView commit details
Commits on Jul 12, 2024
-
I missed some changes when I was playing with PluginProperties. The plugin name will always be a string.
Configuration menu - View commit details
-
Copy full SHA for 86d8213 - Browse repository at this point
Copy the full SHA 86d8213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6042902 - Browse repository at this point
Copy the full SHA 6042902View commit details -
feat!(plugins): remove extract_plugin_properties
Moves the logic from extract_plugin_properties directly into PluginProperties.unmarshal()
Configuration menu - View commit details
-
Copy full SHA for 95e5fa6 - Browse repository at this point
Copy the full SHA 95e5fa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b26111 - Browse repository at this point
Copy the full SHA 6b26111View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dc9145 - Browse repository at this point
Copy the full SHA 5dc9145View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48363d3 - Browse repository at this point
Copy the full SHA 48363d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c553609 - Browse repository at this point
Copy the full SHA c553609View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.