Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: restructure plugin models #775

Merged
merged 11 commits into from
Jul 12, 2024

Commits on Jul 10, 2024

  1. chore!: remove PluginModel class

    This class was vestigial, being a child of PluginPropertiesModel, while
    all plugins' properties classes are children of PluginProperties,
    which is itself a child of PluginPropertiesModel.
    
    This is a breaking change because external plugins for applications
    (e.g. snapcraft) inherit from both PluginProperties and PluginModel.
    lengau committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    257af9f View commit details
    Browse the repository at this point in the history
  2. feat!(plugins): make PluginProperties more complete

    This does several things:
    
    - Merges PluginProperties and PluginPropertiesModel
    - Makes PluginProperties.unmarshal() work for most plugins be default
    - Makes PluginProperties.marshal() fully dump json-able objects
    - Adds a `plugin` field to all plugins, providing their names.
    lengau committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2d2e216 View commit details
    Browse the repository at this point in the history
  3. fix: fix integration tests

    lengau committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1899868 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3d9308d View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. fix: pr comment

    I missed some changes when I was playing with PluginProperties.
    The plugin name will always be a string.
    lengau committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    86d8213 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6042902 View commit details
    Browse the repository at this point in the history
  3. feat!(plugins): remove extract_plugin_properties

    Moves the logic from extract_plugin_properties directly into
    PluginProperties.unmarshal()
    lengau committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    95e5fa6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b26111 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5dc9145 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    48363d3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c553609 View commit details
    Browse the repository at this point in the history