chore: pydantic 2 related cleanup #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class was vestigial, being a child of PluginPropertiesModel, while all plugins' properties classes are children of PluginProperties, which is itself a child of PluginPropertiesModel. This is a breaking change because external plugins for applications (e.g. snapcraft) inherit from both PluginProperties and PluginModel.
This does several things: - Merges PluginProperties and PluginPropertiesModel - Makes PluginProperties.unmarshal() work for most plugins be default - Makes PluginProperties.marshal() fully dump json-able objects - Adds a `plugin` field to all plugins, providing their names.
I missed some changes when I was playing with PluginProperties. The plugin name will always be a string.
Moves the logic from extract_plugin_properties directly into PluginProperties.unmarshal()
This allows sourcess to be validated using pydantic validation as well as the auto-generation of json schemas for sources.
We don't have control here - either mypy is going to complain or pyright is, and in this case pyright is more correct.
It is intentional that we change this to an incompatible type.
…3/3-source-models
While we're at it, make it generic :-)
1 task
dariuszd21
approved these changes
Jul 15, 2024
Co-authored-by: Dariusz Duda <[email protected]>
mr-cal
approved these changes
Jul 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #775