Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise the more specific FileNotFoundError #802

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

mattculler
Copy link
Contributor

  • Have you signed the CLA?

It's counter-intuitive to talk about the FS not being able to read xattrs when the file doesn't exist.

(CRAFT-3031)

@mattculler mattculler self-assigned this Aug 8, 2024
@mattculler mattculler marked this pull request as ready for review August 8, 2024 17:07
@mattculler mattculler requested a review from a team August 8, 2024 18:04
craft_parts/xattrs.py Show resolved Hide resolved
@mr-cal mr-cal requested a review from lengau August 8, 2024 18:22
@lengau
Copy link
Contributor

lengau commented Aug 8, 2024

Thank you! Please let me merge this as I'd like to bring it in between merging #803 and tagging the release.

@mattculler
Copy link
Contributor Author

Thank you! Please let me merge this as I'd like to bring it in between merging #803 and tagging the release.

You got it!

@lengau lengau merged commit 988ebec into main Aug 8, 2024
10 checks passed
@lengau lengau deleted the fix/file-no-found-xattrs branch August 8, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants