Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): add poetry plugin #820

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Aug 19, 2024

  • Have you signed the CLA?

Fixes #707

Tests are failing because I'm battling with CI, but passing locally. Reviews requested so you can review while I'm still battling there.

@lengau lengau force-pushed the work/707/poetry branch 4 times, most recently from 62c93cd to 08f551c Compare August 19, 2024 23:06
@lengau lengau changed the base branch from main to feature/poetry-plugin August 22, 2024 18:27
@lengau lengau marked this pull request as ready for review August 23, 2024 16:54
@lengau lengau mentioned this pull request Aug 23, 2024
1 task
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

.github/workflows/tests.yaml Show resolved Hide resolved
craft_parts/plugins/base.py Show resolved Hide resolved
craft_parts/plugins/poetry_plugin.py Outdated Show resolved Hide resolved
craft_parts/plugins/poetry_plugin.py Outdated Show resolved Hide resolved
@lengau lengau requested a review from tigarmo August 23, 2024 21:40
@lengau
Copy link
Contributor Author

lengau commented Aug 23, 2024

Re-requesting approval from @tigarmo since I made some pretty big changes

Copy link
Collaborator

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@lengau lengau merged commit ee47801 into feature/poetry-plugin Aug 26, 2024
10 checks passed
@lengau lengau deleted the work/707/poetry branch August 26, 2024 14:17
lengau added a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry Python plugin
3 participants