-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: only use Python 3.10+ #827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already happening thanks to tox changes, but this does do unit tests on 3.13 on focal now too.
tigarmo
approved these changes
Aug 22, 2024
Please fix the "unly" on the commit message (😆) |
lengau
force-pushed
the
ci/remove-focal
branch
from
August 22, 2024 18:09
96d5759
to
fded5cb
Compare
@tigarmo fixed. Also re-requested you since I did some other cleanup too |
tigarmo
approved these changes
Aug 22, 2024
cmatsuoka
reviewed
Aug 22, 2024
cmatsuoka
approved these changes
Aug 22, 2024
I think we'll need @mr-cal's assistance to fix the required tests list in order to land this. |
@cmatsuoka could you change the required ci items to match my typo fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already happening thanks to tox changes, but this does do unit tests on 3.13 on focal now too.