Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get assertions for aliased snaps #671

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: get assertions for aliased snaps #671

merged 1 commit into from
Oct 2, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 2, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Use the snap name when getting a declaration assertion from snapd.

Same as #670, but for 1.20.

Unblocks canonical/snapcraft#4683
Unblocks canonical/snapcraft#4927
Unblocks canonical/charmcraft#1770
Fixes #622
(CRAFT-3259)
(CRAFT-3351)

@mr-cal mr-cal requested a review from a team October 2, 2024 21:32
@mr-cal mr-cal merged commit 4fbc046 into hotfix/1.20 Oct 2, 2024
13 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3259/snap-alias-1.20 branch October 2, 2024 23:14
@mr-cal mr-cal removed the request for review from a team October 2, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@sergiusens sergiusens sergiusens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-cal @sergiusens @lengau