Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge KF-5526-issuer-url-dev-branch into main #211

Merged
merged 4 commits into from
Jul 25, 2024
Merged

feat: merge KF-5526-issuer-url-dev-branch into main #211

merged 4 commits into from
Jul 25, 2024

Commits on Jul 24, 2024

  1. feat: add dex_oidc_config library (#208) 

    * feat: add dex_oidc_config library

Add a library to handle the dex-oidc-config relation interface. This library
allows dex-auth to share its OIDC configuration with OIDC clients such as the
oidc-gatekeeper charm. The library is designed to be extended to share any
information about Dex, but right now it is only sharing Dex's issuer url.

Closes #203
    @DnPlas
    DnPlas committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7fd5b15 View commit details
    Browse the repository at this point in the history

  2. refactor: add dex-issuer-url and remove public-url config options (#209) 

    * refactor: add dex-issuer-url and remove public-url config options

This commit removes the public-url configuration option in favour of the dex-issuer-url one.
The way to configure the issuer value for dex-auth is now by getting it from the aforementioned
configuration option or by constructing it from dex-auths Kubernetes Service DNS name:
"http://<dex-app-name>.<namespace>.svc:5556/dex"

Closes #204
    @DnPlas
    DnPlas committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    98ff8bf View commit details
    Browse the repository at this point in the history

  3. Update tests/unit/test_charm.py 

    Co-authored-by: Robert Gildein <[email protected]>
    @DnPlas @rgildein
    DnPlas and rgildein committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7954450 View commit details
    Browse the repository at this point in the history

  4. chore: keep public-url config option for compatibility (#213) 

    Since this is a breaking change, it is preferrable to keep some sort of compatibility that
allow users with existing deployments to keep running Dex even after the upgrade.
This configuration option can be removed after a deprecation notice is rolled out.
    @DnPlas
    DnPlas committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f94ada1 View commit details
    Browse the repository at this point in the history