feat: add Terraform module for dex-auth #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the terraform/ directory to the root of the repository to host the Terraform module of this charm. This follows the standard set in CC006. For more information please also refer to canonical/argo-operators/pull/198. Fixes #226
orfeas-k
reviewed
Sep 19, 2024
mvlassis
previously approved these changes
Sep 20, 2024
The latest standard for the terraform/ README.md is that the compatibility note can be obviated since the module at the branch is compatible with the charm in the same branch. Part of #266
orfeas-k
approved these changes
Sep 24, 2024
DnPlas
added a commit
that referenced
this pull request
Sep 24, 2024
* feat: add Terraform module for dex-auth This commit adds the terraform/ directory to the root of the repository to host the Terraform module of this charm. This follows the standard set in CC006. For more information please also refer to canonical/argo-operators/pull/198. Part of #226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the terraform/ directory to the root of the repository to host the Terraform module of this charm. This follows the standard set in CC006. For more information please also refer to canonical/argo-operators/pull/198.
Part of #226
Testing instructions
tox -e tflintterraform apply -var "channel=latest/edge" -var "model_name=kubeflow" --auto-approveFor reviewers
This module must expose all the information in the
metadata.yamlof this charm, make sure you review it by comparing that file to the Tf files in this PR.