Skip to content

Commit

Permalink
backport(fix): Rename relation to grafana-dashboard from #79 (#81)
Browse files Browse the repository at this point in the history
* Rename relation from `grafana-dashboards` to `grafana-dashboard` in order to:
  * follow what every other CKF charm does.
  * not diverge from the grafana library default.

Ref canonical/bundle-kubeflow#856
Ref canonical/bundle-kubeflow#834
  • Loading branch information
orfeas-k authored Apr 9, 2024
1 parent b1f115e commit 1edb384
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ provides:
versions: [v1]
metrics-endpoint:
interface: prometheus_scrape
grafana-dashboards:
grafana-dashboard:
interface: grafana_dashboard
requires:
grpc:
Expand Down
2 changes: 1 addition & 1 deletion src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def __init__(self, *args):

self.dashboard_provider = GrafanaDashboardProvider(
self,
relation_name="grafana-dashboards",
relation_name="grafana-dashboard",
)

for event in [
Expand Down

0 comments on commit 1edb384

Please sign in to comment.