Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana integration leaves no data dashboards #73

Closed
natalytvinova opened this issue Mar 6, 2024 · 3 comments · Fixed by #80
Closed

Grafana integration leaves no data dashboards #73

natalytvinova opened this issue Mar 6, 2024 · 3 comments · Fixed by #80
Labels
bug Something isn't working

Comments

@natalytvinova
Copy link

natalytvinova commented Mar 6, 2024

Bug Description

I deployed COS and integrated it with envoy:

$   juju status --relations | grep envoy
envoy                                  res:oci-image@cc06b3e    active       1  envoy                     2.0/stable           101  10.152.183.122  no       
grafana-agent-envoy                    0.35.2                   active       1  grafana-agent-k8s         latest/stable         58  10.152.183.22   no       
envoy/5*                                  active       idle   192.168.13.250   9090,9901/TCP  
grafana-agent-envoy/0*                    active       idle   192.168.212.194                 
cos-loki:logging                                                   grafana-agent-envoy:logging-consumer                     loki_push_api             regular  
cos-prometheus:receive-remote-write                                grafana-agent-envoy:send-remote-write                    prometheus_remote_write   regular  
envoy:grafana-dashboards                                           cos-grafana:grafana-dashboard                            grafana_dashboard         regular  joining  
envoy:grafana-dashboards                                           grafana-agent-envoy:grafana-dashboards-consumer          grafana_dashboard         regular  
envoy:metrics-endpoint                                             grafana-agent-envoy:metrics-endpoint                     prometheus_scrape         regular  
grafana-agent-envoy:grafana-dashboards-provider                    cos-grafana:grafana-dashboard                            grafana_dashboard         regular  
grafana-agent-envoy:peers                                          grafana-agent-envoy:peers                                grafana_agent_replica     peer     
istio-pilot:ingress                                                envoy:ingress                                            ingress                   regular  
mlmd:grpc                                                          envoy:grpc                                               grpc                      regular  

As you can see a lot of dashboards have no data:
Screenshot from 2024-03-04 12-15-19

To Reproduce

  1. Juju deploy COS
  2. Juju deploy kubeflow 1.8
  3. Integrate it

Environment

Relevant Log Output

-

Additional Context

No response

@natalytvinova natalytvinova added the bug Something isn't working label Mar 6, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5424.

This message was autogenerated

@orfeas-k
Copy link
Contributor

orfeas-k commented Mar 7, 2024

My guess is that all metrics work, but there are no data on some (I 've seen total requests work) because the metrics exposed are irrelevant to the kind of usage we do for envoy. But we 'll need to confirm and even if I am right, we need to adjust the dashboard to present data users need. So I 'll link this to the Grafana tracker issue.

@orfeas-k
Copy link
Contributor

orfeas-k commented Apr 5, 2024

An update on this, I 've sent a PR that fixes some of the panels. That being said, and this is true for all dashboards, it's normal for some of the panels to have no data since a workload may not provide every metric at every point in time. Thus, if it hasn't provided any scrape data about a specific panel yet, it is expected for this panel to show "No data".

orfeas-k added a commit that referenced this issue Apr 5, 2024
* Add `ckf` tag to the grafana dashboard.
* Fix dashboard panels not working by: 
  * Replacing unavailable metrics with available ones
  * Adding 2 minutes instead of 1 in places where rate() is used since
    this requires more than one scrape data points.
  * Remove rate() from panels that shows percentages.
  * Remove labels where the metrics don't provide them.

Part of canonical/bundle-kubeflow#856
Refs canonical/bundle-kubeflow#834
Closes #73
orfeas-k added a commit that referenced this issue Apr 9, 2024
* Add `ckf` tag to the grafana dashboard.
* Fix dashboard panels not working by: 
  * Replacing unavailable metrics with available ones
  * Adding 2 minutes instead of 1 in places where rate() is used since
    this requires more than one scrape data points.
  * Remove rate() from panels that shows percentages.
  * Remove labels where the metrics don't provide them.

Part of canonical/bundle-kubeflow#856
Refs canonical/bundle-kubeflow#834
Closes #73
orfeas-k added a commit that referenced this issue Apr 9, 2024
* Add `ckf` tag to the grafana dashboard.
* Fix dashboard panels not working by: 
  * Replacing unavailable metrics with available ones
  * Adding 2 minutes instead of 1 in places where rate() is used since this requires more than one scrape data points.
  * Remove rate() from panels that shows percentages.
  * Remove labels where the metrics don't provide them.

Part of canonical/bundle-kubeflow#856
Ref canonical/bundle-kubeflow#834
Ref #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants