Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/v2: add GetControllerLocations endpoint #84

Merged
merged 1 commit into from
Apr 26, 2016
Merged

internal/v2: add GetControllerLocations endpoint #84

merged 1 commit into from
Apr 26, 2016

Conversation

rogpeppe
Copy link

This enables a client to find (for example) all possible values for
clouds and regions.

@mhilton
Copy link

mhilton commented Apr 26, 2016

👍

@@ -325,6 +327,51 @@ func (h *Handler) ListController(arg *params.ListController) (*params.ListContro
}, nil
}

// GetControllerLocations returns all the available values for a given controller
// location attribute. The set of controllers is constrained by the URL query
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/attribute./attributes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we're only returning values for a single attribute.

@urosj
Copy link

urosj commented Apr 26, 2016

👍 with the added branch for authorization.

@rogpeppe
Copy link
Author

:shipit:

@jujugui
Copy link

jujugui commented Apr 26, 2016

Status: merge request accepted. Url: http://ci.theblues.io:8080/job/jem-merge

@jujugui jujugui merged commit 71f409b into canonical:master Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants