Refactor the add model method. #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
approved these changes
Feb 17, 2023
internal/jimm/model.go
Outdated
| } | ||
|
|
||
| // WithConfig returns a builder with the specified model config. | ||
| func (b *modelBuilder) WithConfig(cfg map[string]interface{}) *modelBuilder { | ||
| func (b *model) WithConfig(ctx context.Context, cfg map[string]interface{}) error { |
There was a problem hiding this comment.
We're not using the ctx in here?
There was a problem hiding this comment.
wanted to keep all methods the same by passing in the context in case we want to log anything in them
internal/jimm/model.go
Outdated
| return b.modelInfo | ||
| } | ||
|
|
||
| func (b *model) withConfigFrom(ctx context.Context, getConfigFunction func(ctx context.Context) (map[string]interface{}, error)) error { |
There was a problem hiding this comment.
What is the benefit of this function rather than the approach before? I.e. getting the config in the calling code and then calling withConfig
There was a problem hiding this comment.
moving more of the logic into the model struct
alesstimec
force-pushed
the
refactor-jimm-add-model
branch
from
17ee58c
to
b38e3f3
Compare
alesstimec
force-pushed
the
refactor-jimm-add-model
branch
from
b7ac8aa
to
b545d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.
Fixes JIRA/GitHub issue number
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers