Skip to content

Commit

Permalink
fix: Add datasource field to dashboard's target and tags (#172)
Browse files Browse the repository at this point in the history
* Add `ckf` and `katib` tag to katib-controller's grafana dashboard.
* Fix `datasource` field
* Fix current experiments & trials panel by:
  * adding a `legendFormat` field
  * converting it to a time series & mapping no value to 0 in order to account
    for the fact that katib-controller doesn't output any `current` metrics when
    there is no experiment or trial running.

Ref canonical/bundle-kubeflow#856
Ref canonical/bundle-kubeflow#834
  • Loading branch information
orfeas-k committed Apr 9, 2024
1 parent edd18fa commit 42b9607
Showing 1 changed file with 17 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
"fieldConfig": {
"defaults": {
"color": {
"mode": "thresholds"
"mode": "palette-classic"
},
"custom": {},
"mappings": [],
"noValue": "0",
"thresholds": {
"mode": "absolute",
"steps": [
Expand Down Expand Up @@ -67,22 +67,24 @@
{
"expr": "katib_experiments_current{status=\"Running\"}",
"interval": "",
"legendFormat": "",
"legendFormat": "Current experiments",
"queryType": "randomWalk",
"refId": "A"
"refId": "A",
"datasource": "${prometheusds}"
},
{
"expr": "katib_trials_current{status=\"Running\"}",
"hide": false,
"interval": "",
"legendFormat": "",
"refId": "B"
"legendFormat": "Current trials",
"refId": "B",
"datasource": "${prometheusds}"
}
],
"timeFrom": null,
"timeShift": null,
"title": "Current Status",
"type": "gauge"
"type": "timeseries"
},
{
"aliasColors": {},
Expand Down Expand Up @@ -137,14 +139,16 @@
"interval": "",
"legendFormat": "Experiments",
"queryType": "randomWalk",
"refId": "A"
"refId": "A",
"datasource": "${prometheusds}"
},
{
"expr": "rate(katib_trial_created_total[60m]) * 60*60",
"hide": false,
"interval": "",
"legendFormat": "Trials",
"refId": "B"
"refId": "B",
"datasource": "${prometheusds}"
}
],
"thresholds": [],
Expand Down Expand Up @@ -191,7 +195,10 @@
],
"schemaVersion": 27,
"style": "dark",
"tags": [],
"tags": [
"ckf",
"katib"
],
"templating": {
"list": []
},
Expand Down

0 comments on commit 42b9607

Please sign in to comment.