Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend integration tests for experiments #105

Merged
merged 52 commits into from
Aug 17, 2023

Conversation

NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Aug 2, 2023

Summary of changes:

CI changes:

  • remove unused microk8s metallb addon
  • added step in integrate.yaml to maximise GH runner space

Note: controller integration tests failing recorded in #119, the controller charm was not touched in this PR.

- make create_experiment test parametrizable
- refactor into utils and tests
- add the file metrics collector example
@NohaIhab NohaIhab requested a review from a team as a code owner August 2, 2023 13:54
@NohaIhab NohaIhab linked an issue Aug 3, 2023 that may be closed by this pull request
@i-chvets
Copy link
Contributor

i-chvets commented Aug 3, 2023

Just a comment on re-organization of test data. A strong suggestion, since we starting to introduce a better organization for our tests in other charms.
Test data is organized in this format (except in your case you do not have data/, since there is no need):

tests/
├── assets
│   ├── crs
│   │   ├── grid-example.yaml
│   │   └── file-metrics-collector.yaml
│   └── data # no need for this folder, just an illustration
│       └── <some-future-json-data>

tests/integration/utils.py Outdated Show resolved Hide resolved
tests/integration/utils.py Outdated Show resolved Hide resolved
Signed-off-by: Phoevos Kalemkeris <[email protected]>
@NohaIhab NohaIhab merged commit b3b6981 into main Aug 17, 2023
14 checks passed
@NohaIhab NohaIhab deleted the kf-4009-feat-integration-tests branch August 17, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests for Katib experiments
4 participants