Add unit and integration tests for kati-ui charm #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests cover basic pebble and leader implementation. Integration test checks if charm builds and deploys and that the katib-ui server is coming up. Relates to canonical#5
DnPlas
reviewed
Sep 21, 2023
There was a problem hiding this comment.
Thanks @bschimke95, looks good to me. Because of how this repository is configured, the CI won't run. I'll duplicate your PR to see the CI running.
|
Closing in favour of #143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests cover basic pebble and leader implementation. Integration test checks if charm builds and deploys and that the katib-ui server is coming up.
Relates to #5