-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Introduce k8s-service-info
between katib-controller and katib-db-manager
#185
Conversation
…NAGER_SERVICE_PORT ENV variable
fe159ba
to
205a140
Compare
KATIB_DB_MANAGER_SERVICE_PORT
in katib-controllerk8s-service-info
between katib-controller and katib-db-manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @orfeas-k, left some comments
this k8s_service_info_requirer_component
module looks reusable, I think it can live in chisme, WDYT?
Replied to all comments. Regarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @orfeas-k !
On second thought discussing with @orfeas-k , we need to merge this PR to main before sending a follow-up PR to modify the tests to not use the local charm. This is because we need the new version of |
Follow up PR to #185 Ref canonical/bundle-kubeflow#893
This PR introduces a
k8s-service-info
between katib-controller and katib-db-manager. This addresses the issue below. Read the summary comment for a quick overview of the issue.Note that this means that
katib-controller
will require a relation tokatib-db-manager
in order to start its pebble service, which we will need to introduce in thelatest/edge
bundle.Testing
3/stable
which points to 3.5.0 which is not broken (apart from the issue with kubeflow-dashboard which you can workaround by refreshing to upstream image).bundle.yaml
as followsThis uses the edited
bundle.yaml
Closes canonical/bundle-kubeflow#893