Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alert rules to katib-controller based on the KF093 spec #231

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Add alert rules to katib-controller based on the KF093 spec #231

merged 2 commits into from
Aug 20, 2024

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Aug 15, 2024 •
edited
Loading

These alert rules provide an overview of all service states.

Using the KubeflowServiceDown or KubeflowServiceIsNotStable filter, the user
can easily see the status of all Kubeflow services.

These changes can be tested by running the following commands:

tox -e integration -- --keep-models
juju -m <model-name> show-unit grafana-agent-k8s/0 --endpoint metrics-endpoint | yq '.[]."relation-info".[]."application-data".alert_rules | fromjson'
# if you have cos deployed
juju consume <controller>:cos.remote-write
juju integrate remote-write grafana-agent-k8s
# open Grafana UI and check if KubeflowServiceDown and KubeflowServiceIsNotStable are there
# you can even stop pebble service to see alert rules firing
kubectl exec -it -n <model-name> pod/<pod-name> -c <workload-container> -- /charm/bin/pebble start <service-name>

part-of: #1026

@rgildein rgildein requested a review from a team as a code owner August 15, 2024 10:21
misohu
misohu approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgildein rgildein merged commit 57bb90d into main Aug 20, 2024
16 checks passed
@rgildein rgildein deleted the chore/KF-6125/add-rules-katib-controller branch August 20, 2024 13:28
@NohaIhab NohaIhab mentioned this pull request Oct 7, 2024
Closed
misohu pushed a commit that referenced this pull request Oct 8, 2024
@rgildein @misohu
Add alert rules to katib-controller based on the KF093 spec (#231)
535aea5 
* Add alert rules to katib-controller based on the KF093 spec

* Delete charms/katib-controller/src/prometheus_alert_rules/unit_unavailable.rule
misohu added a commit that referenced this pull request Oct 11, 2024
@misohu @rgildein
Add alert rules to katib-controller based on the KF093 spec (#231) (#243
90399ef 
)

* Add alert rules to katib-controller based on the KF093 spec

* Delete charms/katib-controller/src/prometheus_alert_rules/unit_unavailable.rule

Co-authored-by: Robert Gildein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misohu misohu misohu approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgildein @misohu