Change override to 'merge' to correctly propagate values from the centraldashboard rock #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvlassis
changed the title
mvlassis
changed the title
orfeas-k
approved these changes
Jul 24, 2024
mvlassis
added a commit
that referenced
this pull request
Jul 24, 2024
…traldashboard rock (#221) * Add working_dir value to charm.py * Add NODE_ENV environment variable to Pebble config layer * Fix linting * Change override strategy of Pebble layer to merge * Remove NODE_ENV environment variable since it is already defined in the rock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue 104 on the kubeflow-rocks repo along with this PR.
This PR changes the override strategy from
replacetomerge. This way, we do not need to set theworking-dirvalue that is needed when integrating with thecentraldashboardrock.