twa: Modify charm message when there is no ingress relation

Modify charm message when there is no ingress relation available.
canonical · Jun 26, 2023 · 6b3c749 · 6b3c749
1 parent 8d06d32
commit 6b3c749
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/charms/tensorboards-web-app/src/charm.py b/charms/tensorboards-web-app/src/charm.py
@@ -207,7 +207,7 @@ def _configure_mesh(self, interfaces) -> None:
                 }
             )
         else:
-            raise ErrorWithStatus("No ingress relation available", BlockedStatus)
+            raise ErrorWithStatus("Please relate to istio-pilot:ingress", BlockedStatus)
 
     def _check_leader(self) -> None:
         """Check if this unit is a leader."""

diff --git a/charms/tensorboards-web-app/tests/integration/test_charm.py b/charms/tensorboards-web-app/tests/integration/test_charm.py
@@ -34,7 +34,7 @@ async def test_build_and_deploy(ops_test: OpsTest):
 
     unit = ops_test.model.applications[APP_NAME].units[0]
     assert unit.workload_status == "blocked"
-    assert unit.workload_status_message == "No ingress relation available"
+    assert unit.workload_status_message == "Please relate to istio-pilot:ingress"
 
 
 @pytest.mark.abort_on_fail

diff --git a/charms/tensorboards-web-app/tests/unit/test_operator.py b/charms/tensorboards-web-app/tests/unit/test_operator.py
@@ -35,7 +35,9 @@ def test_no_relation(self, k8s_resource_handler: MagicMock, harness: Harness):
         """Test that charm is blocked when there is no ingress relation."""
         harness.set_leader(True)
         harness.begin_with_initial_hooks()
-        assert harness.charm.model.unit.status == BlockedStatus("No ingress relation available")
+        assert harness.charm.model.unit.status == BlockedStatus(
+            "Please relate to istio-pilot:ingress"
+        )
 
     @patch("charm.KubernetesServicePatch", lambda x, y, service_name: None)
     @patch("charm.TensorboardsWebApp.k8s_resource_handler")