Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database table page; fix broken link #107

Conversation

nielsenjared
Copy link
Contributor

This PR refers to canonical/open-documentation-academy#78

It adds the missing "Renaming a database table" and fixes the corresponding link in live-patching.rst. I put the file in the how-to directory. Let me know if it needs to be placed in another directory and if it needs to be added to an index.rst to address the toctree error.

@jugmac00
Copy link
Member

jugmac00 commented Sep 5, 2024

@nielsenjared Could you please look into the build failures? It looks like the newly added page adds some spelling errors.

Thank you!

@jugmac00
Copy link
Member

jugmac00 commented Sep 6, 2024

Also, please add the newly added file to the appropriate index.rst. Thank you!

@jugmac00 jugmac00 added the Open Documentation Academy Community contribution via https://canonical.com/documentation/open-documentation-academy label Oct 9, 2024
@alvaro-crespo alvaro-crespo merged commit c690ef5 into canonical:main Oct 9, 2024
2 checks passed
@alvaro-crespo
Copy link
Contributor

alvaro-crespo commented Oct 9, 2024

Thanks for the help @nielsenjared ! Changes look good to me. I've just fixed the reference link adding again ../ and then changed the format of the missing page to show it in sql code format (fyi this is done with ..code-block: sql).

@nielsenjared nielsenjared deleted the ODA78-Launchpad_fix_broken_links-database_table branch October 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Open Documentation Academy Community contribution via https://canonical.com/documentation/open-documentation-academy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants