Upload image to temporary dir and then move it #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
reviewed
Mar 29, 2024
MusicDin
force-pushed
the
feat/tmp-img-upload
branch
2 times, most recently
from
243cdec
to
5dba6eb
Compare
simondeziel
previously approved these changes
Mar 29, 2024
First upload contents to the temporary dir and once fully uploaded move the directory to the final destination to avoid potential race where simplestream-maintainer can pick the partially uploaded image. Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
feat/tmp-img-upload
branch
from
5dba6eb
to
f6fa797
Compare
tomponline
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload contents of the built image to the temporary dir and only once fully uploaded move the directory to the final destination to avoid making partially uploaded images available in the simplestream index.
Closes canonical/lxd#13191