Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance: Handle SELinux for VM LXD agent #12881

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Instance: Handle SELinux for VM LXD agent #12881

merged 1 commit into from
Feb 14, 2024

Conversation

MusicDin
Copy link
Member

Cherry picked from lxc/incus#489

tomponline
tomponline reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simondeziel does this need to go into the systemd units package too?

@tomponline
Copy link
Member

@simondeziel does this need to go into the systemd units package too?

I suppose not as Ubuntu doesn't use selinux right?

simondeziel
simondeziel reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu supports using SELinux but it's not a pleasant experience I've heard. That said, those changes should indeed go in the lxd-agent-loader too.

lxd/instance/drivers/driver_qemu.go Outdated Show resolved Hide resolved
@simondeziel
Copy link
Member

@simondeziel does this need to go into the systemd units package too?

https://code.launchpad.net/~sdeziel/ubuntu/+source/lxd-agent-loader/+git/lxd-agent-loader/+merge/460458

@stgraber @MusicDin
lxd/instance/drivers/qemu: Handle SELinux for LXD agent
12d8715 
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit b2cd793ae4ce016ca7da128cc2d14544c041c801)
Signed-off-by: Din Music <[email protected]>
License: Apache-2.0
@tomponline tomponline changed the title Handle SELinux for LXD agent Instance: Handle SELinux for VM LXD agent Feb 14, 2024
@tomponline tomponline merged commit 50f721c into canonical:main Feb 14, 2024
27 checks passed
@MusicDin MusicDin deleted the cp/fix/selinux branch February 14, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simondeziel simondeziel simondeziel left review comments

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MusicDin @tomponline @simondeziel @stgraber