Device: Fix diskAddRootUserNSEntry to add root mapping only if it's required #13332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mapping only if it's required
Fix diskAddRootUserNSEntry logic to correcly handle case when
we have not-groupped UID/GID mapping like this:
[{true false 1000 0 1} {false true 1000 0 1}]
because right now it assumes that mapping should be like
[{true true 1000 0 1}]
which is logically equivalent.
This become noticable after my change in canonical#12718, before that
this issue in logic was reproducible only if user will do something like this:
cat << EOF
uid $(id -u) 1000000
gid $(id -g) 1000000
EOF
) | lxc config set idmap raw.idmap -
which is an extremely rare usecase.
Fixes: canonical#13325
Signed-off-by: Alexander Mikhalitsyn <[email protected]>
tomponline
changed the title
tomponline
approved these changes
Apr 16, 2024
|
Thanks @mihalicyn Please can you add a test for this to https://github.com/canonical/lxd-ci/blob/main/tests/storage-disks-vm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix diskAddRootUserNSEntry logic to correcly handle case when we have not-groupped UID/GID mapping like this:
[{true false 1000 0 1} {false true 1000 0 1}]because right now it assumes that mapping should be like [{true true 1000 0 1}]
which is logically equivalent.
This become noticable after my change in #12718, before that this issue in logic was reproducible only if user will do something like this:
cat << EOF
uid $(id -u) 1000000
gid $(id -g) 1000000
EOF
) | lxc config set idmap raw.idmap -
which is an extremely rare usecase.
Fixes: #13325