Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.0 #13437

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 6, 2024

Bumps google.golang.org/protobuf from 1.33.0 to 1.34.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from tomponline as a code owner May 6, 2024 10:21
Bumps google.golang.org/protobuf from 1.33.0 to 1.34.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/main/google.golang.org/protobuf-1.34.0 branch from f42daa5 to 4e04448 Compare May 6, 2024 12:49
@simondeziel
Copy link
Member

simondeziel commented May 6, 2024

This failed CI because of a new dependency for the lxd-agent: +google.golang.org/protobuf/internal/editionssupport

@simondeziel
Copy link
Member

I just checked and the resulting lxc binary is the exact same size before and after adding that dependency.

@simondeziel
Copy link
Member

It's not the client but lxd-agent and the size is roughly the same. On main, lxd-agent is 17154888 bytes while with this PR it would be 17159496 bytes. So 4.5KiB bigger. Seems fine to me.

The other PRs that are "in-flight" will shrink it further than this anyway.

@tomponline tomponline merged commit 6e0257a into main May 6, 2024
29 checks passed
@tomponline tomponline deleted the dependabot/go_modules/main/google.golang.org/protobuf-1.34.0 branch May 6, 2024 16:07
@simondeziel
Copy link
Member

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github May 6, 2024

Looks like this PR has already been merged. If you've moved back to an older version of google.golang.org/protobuf a new PR will be created next time Dependabot checks your dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants