Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: configure cloud-init from a file #13455

Merged
merged 2 commits into from
May 17, 2024

Conversation

elenapons
Copy link
Contributor

@elenapons elenapons requested a review from tomponline as a code owner May 7, 2024 09:53
@github-actions github-actions bot added the Documentation Documentation needs updating label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Heads up @ru-fu - the "Documentation" label was applied to this issue.

@roosterfish
Copy link
Contributor

Thanks for the contribution.

Could you please sign off your commits? See https://github.com/canonical/lxd/pull/13455/checks?check_run_id=24672808891.

Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elenapons !
Two small comments, otherwise this looks great!

doc/cloud-init.md Outdated Show resolved Hide resolved
doc/cloud-init.md Outdated Show resolved Hide resolved
Co-authored-by: Ruth Fuchss <[email protected]>
Signed-off-by: Elena Pons <[email protected]>
@ru-fu
Copy link
Contributor

ru-fu commented May 8, 2024

Thanks @elenapons !

Before we can actually merge this, you'll need to sign the CLA. See here: https://ubuntu.com/legal/contributors

@elenapons
Copy link
Contributor Author

I thought I did that yesterday. I just signed it again, maybe the issue is that my personal email is private in my Github account.

@ru-fu
Copy link
Contributor

ru-fu commented May 8, 2024

I thought I did that yesterday. I just signed it again, maybe the issue is that my personal email is private in my Github account.

I think it goes by the user name, so that shouldn't be a problem. 🙂
It can take up to 24 hours to register though, so that's probably the case here. I'll rerun the check later. :)

@elenapons
Copy link
Contributor Author

I see 2 errors in the "check if CLA signed" action step:

Checking the following user on Launchpad:

I've made my email public on GitHub, which is the same I used for the Launchpad account.

Checking the following users on GitHub:
Check in the signed list service
Error occurred while checking user: self signed certificate

I don't know what I should do to correct this.

@ru-fu
Copy link
Contributor

ru-fu commented May 13, 2024

It was actually an issue with the CLA check, which seems to have been resolved now, so the check is green. :)
I don't think you need to have your email public - the check runs against both GitHub and Launchpad, but one of them is sufficient.

Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tomponline
Copy link
Member

Thanks!

@tomponline tomponline merged commit d7b8a9f into canonical:main May 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LXD: configure cloud-init from a file
4 participants