Fix unnecessary quota updates #13813
Conversation
Signed-off-by: Marius Klocke <[email protected]>
mariusklocke
force-pushed
the
fix-unnecessary-quota-updates
branch
from
473b4f3
to
20d26ba
Compare
|
I just rebased after merge of #13815 |
|
I just signed the CLA. Can somebody re-run the CI and assign a reviewer? |
|
@mariusklocke i requested it get refreshed and then i can re-run the check |
|
@tomponline I signed up for Launchpad / Ubuntu One yesterday. Can you re-run the check? //edit: Just saw, that the check ran an hour ago. Now says "has not signed the CLA". I just filled the form here. But there is no signature field in these forms? What am I supposed to do here? |
|
@mariusklocke thanks if you've submitted that form, then ill ask them to refresh the list internally (its manual at the moment). |
|
@tomponline Pipeline is still red. Is there anything to do for me here? |
|
We were waiting for an internal refresh from Canonical's web team for the CLA list, I believe this has been done now, but GH isn't offering me the retry test button. Also I've asked @hamistao to look through this PR too. |
|
@hamistao once you've reviewed this PR, there is also a PR of the same thing going into Incus lxc/incus#1163 so it may turn out easier to cherry-pick that (once merged) if the CLA check isn't going to pass. |
|
@mariusklocke The changes look fine but we will cherry pick a similar commit from Incus to bypass the CLA check. Sorry for the delay on the review and thanks for the report and the solution! |
|
@hamistao Fine by me! Can you make the fix available in a 5.21.x version? |
Fixes #13115 This avoids setting project quotas when the project does not change ([from Incus](lxc/incus#1163)), and also avoids unnecessary project setting on `DeleteProject`. Reported-by: Marius Klocke [[email protected]](mailto:[email protected]) Closes #13813
Yeah ill include this in back ports so goes into next 5.21.x release |
This is a bugfix for the issue reported here. I also removed the call to
deleteProject, because in case a project ID has actually changed, it does not make sense to update the file attributes twice.If want to emphasize that this is not only a performance tweak. The iteration of all files of a container can take several minutes. If a file gets deleted after LXD has build its file list and before the file attributes update has been performed, a disk resize operation will fail due to "no such file or directory" error. I observed this error multiple times in a productive workload.
If there are any questions, please ask.