Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxd/storage/drivers: Don't force mount for ext4 resize #14151

Closed

Conversation

MggMuggins
Copy link
Contributor

Work around this kernel bug by not forcing online resize of ext4 volumes.

Reverts #14146

@MggMuggins MggMuggins force-pushed the dont-force-mount-for-ext4-resize branch 2 times, most recently from 28090eb to 1b30044 Compare September 23, 2024 20:49
@simondeziel
Copy link
Member

https://github.com/canonical/lxd/actions/runs/11002177644/job/30549015426?pr=14151#step:12:20644

 - Project: p1, Instance: c1: Failed to update device "root": Could not grow underlying "ext4" filesystem for "/dev/lxdtest-08C/containers_p1_c1": Failed to run: e2fsck -f /dev/lxdtest-08C/containers_p1_c1: exit status 8 (e2fsck 1.46.5 (30-Dec-2021)
e2fsck: need terminal for interactive repairs)

This is getting interesting. Why does it needs repairing?!

@MggMuggins MggMuggins force-pushed the dont-force-mount-for-ext4-resize branch from 1b30044 to 1722ee4 Compare September 23, 2024 21:15
@MggMuggins
Copy link
Contributor Author

Gonna try with -p (less aggressive than -y) to see if those repairs can be automated. We're eating stdout now since #14130 but I could try and spit that out too if you'd like.

@simondeziel
Copy link
Member

Yeah, getting stdout might be handy at some point. As for preen'ing the FS, it seems to be working so far but I really question why repairing is needed. I've yet to manually try it out and see if e2fsck insists on a terminal even in the happy case.

@MggMuggins
Copy link
Contributor Author

Going to close in favor of #14154; will try to file an issue for the e2fsck stuff later today

@MggMuggins MggMuggins closed this Sep 24, 2024
@MggMuggins
Copy link
Contributor Author

I've run this a couple of times with better logging; looks like it's just a leftover mount:

ERROR  [2024-09-25T22:52:24Z] e2fsck                                        err="Failed to run: e2fsck -f -p /dev/lxdtest-kvGy1OUW7-pool6-newName/containers_c12pool6: exit status 8 (e2fsck: Cannot continue, aborting.)" stdout="/dev/lxdtest-kvGy1OUW7-pool6-newName/containers_c12pool6 is mounted.\n"
ERROR  [2024-09-25T22:54:13Z] e2fsck                                        err="Failed to run: e2fsck -f -p /dev/lxdtest-ps2/containers_quota1: exit status 8 (e2fsck: Cannot continue, aborting.)" stdout="/dev/lxdtest-ps2/containers_quota1 is mounted.\n"
ERROR  [2024-09-25T22:54:24Z] e2fsck                                        err="Failed to run: e2fsck -f -p /dev/lxdtest-ps2/containers_quota2: exit status 8 (e2fsck: Cannot continue, aborting.)" stdout="/dev/lxdtest-ps2/containers_quota2 is mounted.\n"
ERROR  [2024-09-25T22:54:34Z] e2fsck                                        err="Failed to run: e2fsck -f -p /dev/lxdtest-ps2/containers_quota3: exit status 8 (e2fsck: Cannot continue, aborting.)" stdout="/dev/lxdtest-ps2/containers_quota3 is mounted.\n"
root size not within quota range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants