Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fetching images across all projects (from Incus) #14260

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add support for fetching images across all projects (from Incus) #14260

wants to merge 9 commits into from

Conversation

kadinsayani
Copy link
Contributor

@kadinsayani kadinsayani commented Oct 10, 2024 •
edited
Loading

Resolves #14126.

This PR adds support for fetching images across all projects by adding a query parameter all-projects.

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Oct 10, 2024
@github-actions GitHub Actions
Copy link

Heads up @mionaalex - the "Documentation" label was applied to this issue.

@kadinsayani kadinsayani force-pushed the 14126-add-all-projects-support-to-fetch-images branch from 80348bf to 9c8ceab Compare October 11, 2024 00:07
tomponline
tomponline reviewed Oct 14, 2024
View reviewed changes
lxd/images.go Outdated Show resolved Hide resolved
tomponline
tomponline requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The all-projects parameter should only change which resources are returned, it should not change the output format.

@kadinsayani kadinsayani force-pushed the 14126-add-all-projects-support-to-fetch-images branch from 9c8ceab to a949a09 Compare October 28, 2024 16:26
@kadinsayani kadinsayani marked this pull request as draft October 28, 2024 16:27
@kadinsayani kadinsayani changed the title Add support for fetching images across all projects WIP: Add support for fetching images across all projects (from Incus) Oct 28, 2024
@kadinsayani kadinsayani force-pushed the 14126-add-all-projects-support-to-fetch-images branch from a949a09 to 5308878 Compare October 29, 2024 09:45
@kadinsayani kadinsayani changed the title WIP: Add support for fetching images across all projects (from Incus) Add support for fetching images across all projects (from Incus) Oct 29, 2024
@kadinsayani kadinsayani marked this pull request as ready for review October 29, 2024 09:49
@kadinsayani
Copy link
Contributor Author

This PR should be good to go. It adds support for the --all-projects flag when running lxc image list. I'm planning to open separate PR's for --all-projects support for network zones, profiles, networks, network-acls, and storage buckets (Incus cherry picks).

markylaing
markylaing requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@markylaing markylaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add something to reduce the number of images returned by the database when the caller is not authenticated?

Other than that I just have a few questions :)

lxd/images.go Outdated Show resolved Hide resolved
client/interfaces.go Outdated Show resolved Hide resolved
lxc/image.go Outdated Show resolved Hide resolved
kadinsayani and others added 2 commits November 6, 2024 10:27
@kadinsayani
api: Add images_all_projects extension
13826ae 
Signed-off-by: Kadin Sayani <[email protected]>
@MaheshPunjabi @kadinsayani
shared/api: Add project property to Image
e2506bc 
Signed-off-by: Mahesh Punjabi <[email protected]>
(cherry picked from commit 087e0b3701787e9ab237d57321aff329b706295b)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@kadinsayani kadinsayani force-pushed the 14126-add-all-projects-support-to-fetch-images branch 4 times, most recently from 53c78dc to 4b4ae6b Compare November 8, 2024 16:23
markylaing
markylaing requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@markylaing markylaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits that should be easy to fix :)

lxd/images.go Outdated Show resolved Hide resolved
lxd/images.go Outdated Show resolved Hide resolved
client/lxd_images.go Outdated Show resolved Hide resolved
client/lxd_images.go Outdated Show resolved Hide resolved
@kadinsayani kadinsayani force-pushed the 14126-add-all-projects-support-to-fetch-images branch 3 times, most recently from 79816ce to 3722085 Compare November 8, 2024 18:53
@kadinsayani
Copy link
Contributor Author

Just a few nits that should be easy to fix :)

Thanks for the review @markylaing :) I think I've addressed everything now.

markylaing
markylaing requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@markylaing markylaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of last bits. Thanks :)

lxd/images.go Show resolved Hide resolved
lxd/images.go Outdated Show resolved Hide resolved
MaheshPunjabi and others added 7 commits November 11, 2024 11:37
@MaheshPunjabi @kadinsayani
lxd/images: Add support for all_projects
7efd66f 
Signed-off-by: Mahesh Punjabi <[email protected]>
(cherry picked from commit a3544074d69dd2438986311d2996a408deb5ad2e)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@kadinsayani
api: Run make update-api
1f896d5 
Signed-off-by: Kadin Sayani <[email protected]>
@MaheshPunjabi @kadinsayani
lxc/client: Add GetImagesAllProjects function
8233e6b 
Signed-off-by: Mahesh Punjabi <[email protected]>
(cherry picked from commit 34ae1bd35a1ea79fb78b06dd0de7eb5f70ccb4a6)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@kadinsayani
lxc/client: Add GetImagesAllProjectsWithFilter function
55f4afb 
Signed-off-by: Kadin Sayani <[email protected]>
@MaheshPunjabi @kadinsayani
lxc/image: Add --all-projects flag to list
5f2406a 
Signed-off-by: Mahesh Punjabi <[email protected]>
(cherry picked from commit f5c5a8170106e94ed314f5761b4b91d9621acc65)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@kadinsayani
i18n: Update translation templates.
e74533e 
Signed-off-by: Kadin Sayani <[email protected]>
@kadinsayani
i18n: Update translations.
3a1f0a2 
Signed-off-by: Kadin Sayani <[email protected]>
@kadinsayani kadinsayani force-pushed the 14126-add-all-projects-support-to-fetch-images branch from 3722085 to 3a1f0a2 Compare November 11, 2024 18:38
@kadinsayani
Copy link
Contributor Author

Just a couple of last bits. Thanks :)

Should be good to go, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline Awaiting requested review from tomponline

@markylaing markylaing Awaiting requested review from markylaing

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add all projects support to fetch images
4 participants
@kadinsayani @tomponline @markylaing @MaheshPunjabi