Set Target after network/storage lookup (from Incus) #14420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes lxc/incus#335 Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit a13184bf72f0d5ad69aa12b7e392bc2c2ff2ec93) Signed-off-by: Mark Laing <[email protected]> License: Apache-2.0
…uster group. Signed-off-by: Mark Laing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LXD init, if the
--storageor--networkflags are provided the CLI will check the storage pool or network exists before setting up a device on the instance config. When targeting a cluster group this would lead to calls likeGET /1.0/storage-pools/foo?target=@barwhich doesn't make sense.This commit (cherry-picked from Incus) moves setting the cluster group target to after those lookups.
I've added tests have checked that they fail before this change and pass afterwards.