Auth: Allow listing unmanaged networks with fine-grained auth #14447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up @mionaalex - the "Documentation" label was applied to this issue. |
markylaing
changed the title
markylaing
changed the title
markylaing
force-pushed
the
bug-fga-network-list
branch
from
4777eac
to
20724a7
Compare
tomponline
reviewed
Nov 12, 2024
lxd/networks.go
Outdated
|
|
||
| err = s.DB.Cluster.Transaction(r.Context(), func(ctx context.Context, tx *db.ClusterTx) error { | ||
| // Get list of managed networks (that may or may not have network interfaces on the host). | ||
| networkNames, err = tx.GetNetworks(ctx, effectiveProjectName) | ||
| networks[0], err = tx.GetNetworks(ctx, effectiveProjectName) |
There was a problem hiding this comment.
please can we have local constants for the magic numbers 0 and 1 so we dont end up with hard to read logic like this:
if !shared.ValueInSlice(iface.Name, networks[0]) {
networks[1] = append(networks[1], iface.Name)
}There was a problem hiding this comment.
Yep sure. I wasn't sure about this either and contemplated using a map but it seemed overkill for something so simple. I'll add some constants.
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
…orks. Signed-off-by: Mark Laing <[email protected]>
markylaing
force-pushed
the
bug-fga-network-list
branch
from
20724a7
to
152584e
Compare
tomponline
approved these changes
Nov 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where fine-grained authorization was filtering out unmanaged networks (because they aren't in the database). To do this I added a new entitlement at the server level:
can_view_unmanaged_networks. Restricted TLS clients are granted this by default to not break existing behaviour.Opening this now but will mark as draft until I add some tests.
Closes #14085