Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Remove gen_cert util #14449

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Tests: Remove gen_cert util #14449

merged 4 commits into from
Nov 12, 2024

Commits on Nov 12, 2024

  1. test/suites: Simplify user_is_server_admin. 

    This test was unnecessarily moving certificates around to test that a
server administrator can create and edit certificates. This is
simplified by using a separate LXD_CONF directory.

Additionally, now use `gen_cert_and_key` instead of `gen_cert`.

Signed-off-by: Mark Laing <[email protected]>
    @markylaing
    markylaing committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    091ca31 View commit details
    Browse the repository at this point in the history

  2. test/suites: Use gen_cert_and_key in basic usage tests. 

    Signed-off-by: Mark Laing <[email protected]>
    @markylaing
    markylaing committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f8d97c5 View commit details
    Browse the repository at this point in the history

  3. test/suites: Use gen_cert_and_key in remote admin tests. 

    Signed-off-by: Mark Laing <[email protected]>
    @markylaing
    markylaing committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    764f253 View commit details
    Browse the repository at this point in the history

  4. test/includes: Remove gen_cert util. 

    This util did not specify the `--auth-type` flag when adding the dummy
remote. This caused issues if another LXD is running on the host machine
while listening on :8443 with OIDC configured. The `remote add` command
would fail and get the OIDC headers, then attempt to start the device
authorization grant flow with the IdP configured on the other LXD. With
`BROWSER=curl` set for use with the `mini-oidc` test util, it was causing
`lxc` to attempt to curl the code verification page.

Since we have a simpler and more efficient equivalent in
`gen_cert_and_key`, I've opted to remove it instead of setting the
`--auth-type` flag to avoid this behaviour.

Signed-off-by: Mark Laing <[email protected]>
    @markylaing
    markylaing committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    84896c2 View commit details
    Browse the repository at this point in the history