Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 2.18.0 Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600

Closed
AlanGriffiths opened this issue Sep 18, 2024 · 3 comments · Fixed by #3599
Closed

Since 2.18.0 Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600

AlanGriffiths opened this issue Sep 18, 2024 · 3 comments · Fixed by #3599
Assignees
Labels

Comments

@AlanGriffiths
Copy link
Contributor

24/candidate: 197-mir2.18.0

$ WAYLAND_DISPLAY=wayland-99 WAYLAND_DEBUG=client wpe-webkit-mir-kiosk.cog 2>&1 | grep -e xdg_toplevel.*configure -e xdg_toplevel.*size -e create_buffer
[3455836.499] [email protected](0, 0, array[0])
[3455836.537] [email protected](0, 0, array[0])
[3455836.552] [email protected](1292, 1054, array[4])
[3455953.107] [email protected](0, 0, array[8])
...

24/stable: 152-mir2.17.0

$ WAYLAND_DISPLAY=wayland-99 WAYLAND_DEBUG=client wpe-webkit-mir-kiosk.cog 2>&1 | grep -e xdg_toplevel.*configure -e xdg_toplevel.*size -e create_buffer
[3582358.284] [email protected](0, 0, array[0])
[3582358.310] [email protected](0, 0, array[0])
[3582358.316] [email protected](1280, 1024, array[4])
[3582477.192] [email protected](1280, 1024, array[8])
...
@AlanGriffiths AlanGriffiths self-assigned this Sep 18, 2024
@AlanGriffiths
Copy link
Contributor Author

AlanGriffiths commented Sep 18, 2024

This can be easily reproduced with the "kiosk" example...

miral-app -kiosk -terminal wpe-webkit-mir-kiosk.cog

And reverting #3575 does fix this problem

@AlanGriffiths
Copy link
Contributor Author

Here's a more detailed log...

$ WAYLAND_DISPLAY=wayland-99 WAYLAND_DEBUG=client wpe-webkit-mir-kiosk.cog 2>&1 | grep -e xdg_toplevel@.* -e xdg_surface@.* -e create_buffer.* -e zwp_linux_buffer_params_v1.*create_immed.*
[ 708945.059]  -> [email protected]_xdg_surface(new id xdg_surface@16, wl_surface@15)
[ 708945.064]  -> [email protected]_toplevel(new id xdg_toplevel@17)
[ 708945.067]  -> [email protected]_title("Cog")
[ 708945.077]  -> [email protected]_app_id("com.igalia.Cog")
[ 708953.263] [email protected](0, 0, array[0])
[ 708953.291] [email protected](103)
[ 708953.294]  -> [email protected]_configure(103)
[ 708953.297] [email protected](0, 0, array[0])
[ 708953.301] [email protected](104)
[ 708953.303]  -> [email protected]_configure(104)
[ 708953.304] [email protected](1280, 1024, array[4])
[ 708953.323] [email protected](105)
[ 708953.325]  -> [email protected]_configure(105)
[ 709066.756]  -> [email protected]_immed(new id wl_buffer@16, 1024, 768, 875713089, 0)
[ 709066.908]  -> [email protected]_immed(new id wl_buffer@23, 1024, 768, 875713089, 0)
[ 709067.409] [email protected](0, 0, array[8])
[ 709067.417] [email protected](106)
[ 709067.419]  -> [email protected]_configure(106)
[ 709080.961]  -> [email protected]_immed(new id wl_buffer@17, 1280, 1024, 875713089, 0)
[ 709082.457]  -> [email protected]_immed(new id wl_buffer@22, 1280, 1024, 875713089, 0)
[ 709121.864]  -> [email protected]_immed(new id wl_buffer@18, 1024, 768, 875713089, 0)
[ 709122.108]  -> [email protected]_immed(new id wl_buffer@24, 1024, 768, 875713089, 0)
[ 709174.703]  -> [email protected]_immed(new id wl_buffer@16, 1024, 768, 875713089, 0)
[ 709174.921]  -> [email protected]_immed(new id wl_buffer@25, 1024, 768, 875713089, 0)
[ 709227.735]  -> [email protected]_immed(new id wl_buffer@26, 1024, 768, 875713089, 0)
[ 709303.365]  -> [email protected]_immed(new id wl_buffer@23, 1024, 768, 875713089, 0)
[ 709374.968]  -> [email protected]_immed(new id wl_buffer@22, 1024, 768, 875713089, 0)
[ 709448.825]  -> [email protected]_immed(new id wl_buffer@24, 1024, 768, 875713089, 0)
[ 709528.511]  -> [email protected]_immed(new id wl_buffer@25, 1024, 768, 875713089, 0)
[ 709597.492]  -> [email protected]_immed(new id wl_buffer@26, 1024, 768, 875713089, 0)
[ 709672.010]  -> [email protected]_immed(new id wl_buffer@23, 1024, 768, 875713089, 0)
[ 709745.729]  -> [email protected]_immed(new id wl_buffer@22, 1024, 768, 875713089, 0)
[ 709879.160]  -> [email protected]_immed(new id wl_buffer@24, 1024, 768, 875713089, 0)
[ 709913.551]  -> [email protected]_immed(new id wl_buffer@25, 1024, 768, 875713089, 0)

Note that WPE does send a couple of correctly sized buffers before reverting to a wrong size

@AlanGriffiths AlanGriffiths changed the title Since 2.18.0 Frame fails to enforce fullscreen Since 2.18.0 Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk Sep 18, 2024
@Saviq
Copy link
Collaborator

Saviq commented Sep 19, 2024

Another symptom of this is https://github.com/canonical/iot-example-graphical-snap/tree/22/Electron-quick-start dying on startup in miral-kiosk / Frame.

@Saviq Saviq mentioned this issue Sep 24, 2024
Saviq added a commit that referenced this issue Sep 27, 2024
Enhancements:
. Allow to specify an app id for when running on the wayland platform #3614

Bugs fixed:
. SIGSEGV on input device disconnection #3601
. Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600
. Chromium unmaximises when focus is lost #3592
. Apps constantly resizing #3573
. Our fork/exec spawning is unsafe #3494
. Revert "Fix random leak" #3609
. Smoke tests are failing #3610
Saviq added a commit that referenced this issue Sep 27, 2024
Enhancements:
. Allow to specify an app id for when running on the wayland platform #3614

Bugs fixed:
. SIGSEGV on input device disconnection #3601
. Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600
. Chromium unmaximises when focus is lost #3592
. Apps constantly resizing #3573
. Our fork/exec spawning is unsafe #3494
. Revert "Fix random leak" #3609
. Smoke tests are failing #3610
github-merge-queue bot pushed a commit that referenced this issue Sep 30, 2024
>  Release 2.18.2
>
>  Enhancements:
>  - #3614
>  - #3617
>
>  Bugs fixed:
>   - #3601
>   - #3600
>   - #3592
>   - #3573
>   - #3494
>   - #3609
>   - #3610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants