Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused mysql relation #73

Closed
DnPlas opened this issue Mar 26, 2024 · 1 comment · Fixed by #75
Closed

Remove unused mysql relation #73

DnPlas opened this issue Mar 26, 2024 · 1 comment · Fixed by #75
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Mar 26, 2024

Context

The charm has a mysql relation that is not used as it is provided by the mariadb charm which is no longer supported. The other alternative is to use the relational-db relation to relate to mysql-k8s charm, but due to #64, it is not possible.

In #71 it was decided that instead of an external DB provider, the mlmd charm will use the SQLite implementation it has been using for a while. In PR#72 the charm code has been modified to exclusively use SQLite.

What needs to get done

Remove the mysql relation from the metadata.yaml file

Definition of Done

The metadata.yaml file does not have the relation.

@DnPlas DnPlas added the enhancement New feature or request label Mar 26, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5484.

This message was autogenerated

DnPlas added a commit that referenced this issue Apr 8, 2024
The charm has a mysql relation that is not used as it is provided by the mariadb charm which is no longer supported.
The other alternative is to use the relational-db relation to relate to mysql-k8s charm, but due to #64, it is not possible.

In #71 it was decided that instead of an external DB provider, the mlmd charm will use the SQLite implementation it has been using for a while.
In PR#72 the charm code has been modified to exclusively use SQLite.

Fixes #73
DnPlas added a commit that referenced this issue Jun 21, 2024
The charm has a mysql relation that is not used as it is provided by the mariadb charm which is no longer supported.
The other alternative is to use the relational-db relation to relate to mysql-k8s charm, but due to #64, it is not possible.

In #71 it was decided that instead of an external DB provider, the mlmd charm will use the SQLite implementation it has been using for a while.
In PR#72 the charm code has been modified to exclusively use SQLite.

Fixes #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant