Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'networkmanager:' backend options for modem connections #179

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

slyon
Copy link
Collaborator

@slyon slyon commented Dec 16, 2020

Description

The COMMON_BACKEND_HANDLERS have been forgotten for modem connections apparently. Add them to allow the definition of the special networkmanager: mapping, used for NetworkManager integration. E.g. this networkmanager.uuid setting:

network:
  version: 2
  renderer: NetworkManager
  modems:
    mycon:
      auto-config: true
      networkmanager:
        uuid: b22d8f0f-3f34-46bd-ac28-801fa87f1eb6

We do not (yet) use that information (like uuid) in the current implementation. But reading YAML via NetworkManager will be broken if the networkmanager: mapping is not accepted.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@codecov-io
Copy link

Codecov Report

Merging #179 (eaff8b1) into master (85ff2f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          49       49           
  Lines        7351     7356    +5     
=======================================
+ Hits         7271     7276    +5     
  Misses         80       80           
Impacted Files Coverage Δ
src/parse.c 100.00% <ø> (ø)
tests/generator/test_modems.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ff2f5...eaff8b1. Read the comment docs.

@slyon slyon requested a review from sil2100 December 16, 2020 17:11
Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks good. I mean, we don't support openvswitch: for modems, but it doesn't really matter.

@sil2100 sil2100 merged commit 41bfbd6 into master Dec 16, 2020
@slyon slyon deleted the slyon/modems-nm-integration branch December 17, 2020 07:00
slyon added a commit to slyon/netplan that referenced this pull request May 21, 2024
@slyon slyon mentioned this pull request May 21, 2024
5 tasks
slyon added a commit to slyon/netplan that referenced this pull request May 21, 2024
slyon added a commit to slyon/netplan that referenced this pull request May 21, 2024
slyon added a commit that referenced this pull request May 21, 2024
daniloegea pushed a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants