Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse-nm: Handle missing gateway in keyfile routes, keep dns-search fallback #238

Merged
merged 4 commits into from
Oct 11, 2021
Merged

parse-nm: Handle missing gateway in keyfile routes, keep dns-search fallback #238

merged 4 commits into from
Oct 11, 2021

Commits on Oct 7, 2021

  1. parse-nm: Handle missing gateway in keyfile routes, keep dns-search f… 

    …allback

NM assumes a route to use the unspecified address as the gateway
(via = "0.0.0.0"/"::") if none is specified in the keyfile.
E.g. the route is only valid on the local network:
"ip route add NETWORK dev DEVICE [metric METRIC]"

netplan cannot differentiate between ipv4.dns-search and ipv6.dns-search
so keep it in the passthrough/fallback list as an override.
    @slyon
    slyon committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    57780ef View commit details
    Browse the repository at this point in the history

  2. parse-nm: Fix typos 

    Co-authored-by: Simon Chopin <[email protected]>
    @slyon @schopin-pro
    slyon and schopin-pro committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    747e02a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. nm:parse-nm: Hide NM's automatic route-scope detection 

    NetworkManager automatically detects a route's scope, depending on
destination IP ("to") and gateway ("via"). If no gateway is specified
(e.g. the unspecified address "0.0.0.0"/"::" in keyfile) it will assume
a "link"/"host" scope, otherwise it will assume a "global" scope.
    @slyon
    slyon committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    03878f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. nm: Do not set missing gateway as unspecified address 

    Also avoid the deprecated trailing comma notation at the same time.
    @slyon
    slyon committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    e697ee6 View commit details
    Browse the repository at this point in the history