Commits on Apr 11, 2022

1. dbus: Remove the upper limit on try timeout …

   Also, increase the default to 10s.
   
   If the caller sees fit to specifiy a 30s timeout for their try call, it
   stands to reason to respect that decision, as they (probably) know
   better.
   
   This issue came up in the Core testsuite, where the netplan
   configuration step failed because `netplan try` took 6s, cf
   LP: #1967084. Their DBus call specifies a timeout of 300s, but the call
   failed after a "relatively short time", which was this internal timeout.
   
   Note that the mere fact that `netplan try` takes more than 5s on such a
   simple configuration is probably due to the following patch:
   
   https://git.launchpad.net/ubuntu/+source/netplan.io/tree/debian/patches/0006-cli-apply-give-some-extra-time-for-networkctl-reload.patch?h=applied/ubuntu/focal-updates
   
   Since the bridge is empty, it might be in a "configuring" state forever.
   
   Granted, that's not something one would do on production systems,
   however creating an empty bridge interface is routinely done in test
   suites, including our own.

   

   schopin-pro committed Apr 11, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for c72bf8c
   • Browse repository at this point

   Copy the full SHA

   c72bf8c View commit details

   Browse the repository at this point in the history