-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation improvements (Diátaxis) (FR-2276) #287
Conversation
76b52f3
to
7633a6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think this looks good. I am not completely sure about if this fully follows Diataxis ideology, but at least it feels structured properly. We might want to ask Daniele for a sign off - but that could be done after this PR is done (no need to block on that).
I like this direction in overall, because this means we'll have all of the documentation bits in one repository (not having to worry about the netplan.io one having contents we have no control over). I see you moved things like the examples section into the netplan docs here.
A bit that's a bit confusing to me is the meson doc situation. I mean, I understand the situation: when we build netplan with meson we care about manpages, and the meson.build
in doc creates manpages with pandoc. But it gets a bit confusing, because you just have to use the Makefile
there to get any other output. It's okay, but it feels a bit disconnected. That being said, not a real problem.
Co-authored-by: Lukas Märdian <[email protected]>
…for local docs development
Thanks for your review! I'm not a Diataxis expert by any means myself, but I tried to move the existing documentation roughly into the Diataxis categories. IMO, fine-tuning those can be an iterative process after we land the initial structure (i.e. this PR).
Yes, I copied over the examples page from https://netplan.io/examples as there has been some confusion about https://netplan.io/examples vs https://github.com/canonical/netplan/tree/main/examples in the past, which we can cover better if we track the examples page as part of the documentation (and maybe converge the two locations in the future). OTOH, I've also added some hyperlinks to external documents under Tutorials, API specification and Explanation (e.g. https://netplan.io/design & https://netplan.io/faq) as I did not want to hijack all of the netplan.io website and drag it into the Documentation, although that might make sense. I guess that's something to be discussed with Daniele.
Indeed, the I've added a comment about this at the top of |
Description
Re-structuring of Netplan's documentation, according to Diátaxis
The primary documentation (YAML config reference) has been refactored, making use of standard Markdown syntax (instead of pandoc specialities), to be able to render to other frontends like Sphinx or Discourse.
This can now be rendered to several frontends (keeping compatibility with old manpages/pandoc):
Checklist
make check
successfully.make check-coverage
).