NetworkManager 1.40 compat & file permission fixes (LP: #1862600, LP: #1997348) #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with NM 1.40 keyfiles can contain an empty [ethernet] section, even on non-ethernet devices (e.g. bridges), but Netplan's "wakeonlan" setting is not supported on those.
The YAML files written might contain sensitive information, such as WiFi passwords. Therefore, they should be root/owner read-only by default.
slyon
changed the title
daniloegea
reviewed
Nov 24, 2022
There was a problem hiding this comment.
Looks good.
It just broke autopkgtest I guess due to the new output.
slyon
force-pushed
the
slyon/nm140-compat
branch
from
f0c6ab7
to
0015204
Compare
YAML files written by the user or a (external) tool (e.g. "netplan set", NetworkManager, subiquity, ...) can contain sensitive information (e.g. WiFi passwords), so should stay secret (root/owner read-only).
slyon
force-pushed
the
slyon/nm140-compat
branch
from
0015204
to
2e09c43
Compare
|
Thanks for your review @daniloegea! I think I addressed all of your comments. |
daniloegea
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
make checksuccessfully.make check-coverage).