Memory leak action

.github/workflows/check-address-sanitizer.yml

@@ -0,0 +1,32 @@
+name: Check for memory issues
+
+# This action will compile netplan with ASAN (address sanitizer) and run
+# all the C unit tests and call the generator for every single file in the
+# examples directory.
+# The job will fail if a memory issue is detected by ASAN.
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ '**' ]
+
+jobs:
+  memory-sanitizer:
+    runs-on: ubuntu-22.04
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Install build depends
+        run: |
+          echo "APT::Get::Always-Include-Phased-Updates \"true\";" | sudo tee /etc/apt/apt.conf.d/90phased-updates
+          sudo sed -i '/deb-src/s/^# //' /etc/apt/sources.list
+          sudo apt update
+          sudo apt -y install python3-rich python3-coverage python3-pytest python3-pytest-cov curl meson gcovr expect libcmocka-dev
+          sudo apt -y build-dep netplan.io
+
+      - name: Run unit tests
+        run: |
+          unbuffer ./tools/run_asan.sh
+

examples/bonding.yaml

@@ -1,6 +1,9 @@
 network:
   version: 2
   renderer: networkd
+  ethernets:
+    enp3s0: {}
+    enp4s0: {}
   bonds:
     bond0:
       dhcp4: yes

examples/direct_connect_gateway.yaml

@@ -2,8 +2,9 @@ network:
   version: 2
   renderer: networkd
   ethernets:
-    addresses: [ "10.10.10.1/24" ]
-    routes:
-      - to: 0.0.0.0/0
-        via: 9.9.9.9
-        on-link: true
+    eth0:
+      addresses: [ "10.10.10.1/24" ]
+      routes:
+        - to: 0.0.0.0/0
+          via: 9.9.9.9
+          on-link: true

examples/direct_connect_gateway_ipv6.yaml

@@ -2,8 +2,9 @@ network:
   version: 2
   renderer: networkd
   ethernets:
-    addresses: [ "2001:cafe:face:beef::dead:dead/64" ]
-    routes:
-      - to: "::/0"
-        via: "2001:cafe:face::1"
-        on-link: true
+    eth0:
+      addresses: [ "2001:cafe:face:beef::dead:dead/64" ]
+      routes:
+        - to: "::/0"
+          via: "2001:cafe:face::1"
+          on-link: true

examples/static_singlenic_multiip_multigateway.yaml

@@ -16,4 +16,4 @@ network:
         metric: 100
       - to: 0.0.0.0/0
         via: 11.0.0.1
-        metric: 100
+        metric: 200

examples/wireguard.yaml

@@ -15,6 +15,7 @@ network:
       routes: 
         - to: default
           via: 10.10.10.21
+          metric: 100
     wg1: #client
       mode: wireguard
       addresses: [20.20.20.10/24]
@@ -29,3 +30,4 @@ network:
       routes: 
         - to: default
           via: 20.20.20.11
+          metric: 200

tools/run_asan.sh

@@ -0,0 +1,26 @@
+#!/bin/bash
+
+set -e
+set -x
+
+BUILDDIR="_leakcheckbuild"
+
+meson setup ${BUILDDIR} -Db_sanitize=address,undefined
+meson compile -C ${BUILDDIR} --verbose
+
+TESTS=$(find ${BUILDDIR}/tests/ctests/ -executable -type f)
+for test in ${TESTS}
+do
+    ./${test}
+done
+
+mkdir -p ${BUILDDIR}/fakeroot/{etc/netplan,run}
+export LD_LIBRARY_PATH="${BUILDDIR}/src"
+
+for yaml in examples/*.yaml
+do
+    cp ${yaml} ${BUILDDIR}/fakeroot/etc/netplan/
+    chmod 600 ${BUILDDIR}/fakeroot/etc/netplan/${yaml##*/}
+    ./${BUILDDIR}/src/generate --root-dir ${BUILDDIR}/fakeroot
+    rm ${BUILDDIR}/fakeroot/etc/netplan/${yaml##*/}
+done