-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: use meson-make-symlink.sh helper script instead of install_symlink() #327
Conversation
…link() This will allow to dynamically adopt the symlinks for usrmerged and non-usrmerged installations, especially: root@ll:~# pkgconf --variable=systemdsystemgeneratordir systemd /lib/systemd/system-generators [root@f37 ~]# pkgconf --variable=systemdsystemgeneratordir systemd /usr/lib/systemd/system-generators Helper script inspired by util-linux 238.1-5 (tools/meson-make-symlink.sh)
This seems to be working for both cases:
|
I've also talked to our systemd maintainer, and we will coordinate with Debian to adopt the systemd packaging to install stuff in |
cc @Conan-Kudo @xnox WDYT about this? |
This needs to be done anyway, since systemd is ripping out support for non-usrmerged systems soon. It'd be great to see this in place for Lunar at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, --relative is best, as this avoids the need for distro packaging tools to fix things up later, like rpm scriplets do, or like dh_link in debian world.
Agreed. Lunar is post-FeatureFreeze already, so unfortunately I doubt the systemd change will still be landed in Lunar. But should be in Lunar+1 |
I think this is honestly worthy of an exception, but my voice doesn't really matter here... |
Your voice and input is highly appreciated! I've been told that some discussion around this usrmerge change has been happening in IRC #debian-systemd recently. But as both Debian and Ubuntu are currently in freeze, I assume the maintainers won't land such impactful change anymore (it will require changes to many more packages, like Netplan, which use systemd's |
Description
meson: use meson-make-symlink.sh helper script instead of install_symlink()
This will allow to dynamically adopt the symlinks for usrmerged and non-usrmerged installations, especially:
root@ll:~# pkgconf --variable=systemdsystemgeneratordir systemd /lib/systemd/system-generators
[root@f37 ~]# pkgconf --variable=systemdsystemgeneratordir systemd /usr/lib/systemd/system-generators
Helper script inspired by util-linux 238.1-5 (tools/meson-make-symlink.sh)
Related to #323
Checklist
make check
successfully.make check-coverage
).