Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netplan: adjust the maximum buffer size to 1MB #340

Merged
merged 1 commit into from
Apr 18, 2023
Merged

netplan: adjust the maximum buffer size to 1MB #340

merged 1 commit into from
Apr 18, 2023

Conversation

daniloegea
Copy link
Collaborator

@daniloegea daniloegea commented Apr 14, 2023 •
edited by slyon
Loading

It says it's 1MB but the value is actually 1GB

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@daniloegea
netplan: adjust the maximum buffer size to 1MB
16e0060 
It says it's 1MB but the value is actually 1GB
@daniloegea daniloegea requested a review from slyon April 17, 2023 14:29
slyon
slyon approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 good catch!

@slyon slyon merged commit fe18135 into canonical:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slyon slyon slyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniloegea @slyon